fix: Parse.Query.findAll not returning all objects with option json: true
#2449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #2449 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 64 64
Lines 6271 6256 -15
Branches 1450 1478 +28
=========================================
- Hits 6271 6256 -15 ☔ View full report in Codecov by Sentry. |
dplewis
changed the title
Parse.Query.findAll not returning all objects with `json: true…Parse.Query.findAll not returning all objects with json option
mtrezza
changed the title
Parse.Query.findAll not returning all objects with json optionParse.Query.findAll not returning all objects with option json: true
mtrezza
reviewed
Feb 14, 2025
Signed-off-by: Manuel <[email protected]>
parseplatformorg
pushed a commit
that referenced
this pull request
Feb 14, 2025
# [5.3.0-alpha.6](5.3.0-alpha.5...5.3.0-alpha.6) (2025-02-14) ### Bug Fixes * `Parse.Query.findAll` not returning all objects with option `json: true` ([#2449](#2449)) ([f160b8c](f160b8c))
|
🎉 This change has been released in version 5.3.0-alpha.6 |
parseplatformorg
pushed a commit
that referenced
this pull request
Mar 2, 2025
# [6.0.0](5.3.0...6.0.0) (2025-03-02) ### Bug Fixes * `Parse.Hooks` requests have double forward slash in URL ([#2441](#2441)) ([1fc520c](1fc520c)) * `Parse.Query.findAll` not returning all objects with option `json: true` ([#2449](#2449)) ([f160b8c](f160b8c)) * Cannot pass `useMasterKey: false` to `Parse.Cloud.run` ([#2431](#2431)) ([abadac9](abadac9)) * Remove validation error handler option `error` from various methods of `Parse.Object` ([#2445](#2445)) ([52ddaee](52ddaee)) * Security upgrade dset from 3.1.3 to 3.1.4 ([#2277](#2277)) ([058f8e4](058f8e4)) ### Features * Add transaction to save and destroy on `Parse.Object` ([#2265](#2265)) ([2b55bdf](2b55bdf)) ### BREAKING CHANGES * Internal REST requests for `Parse.Hooks` use a URL that contains a double forward slash, for example `http://localhost/parse//hooks/functions`. This release changes the double forward slash to a single forward slash. ([1fc520c](1fc520c)) * Removes the error handler option `error` from `Parse.Object.set`, `Parse.Object.setACL`, `Parse.Object.unset`, `Parse.Role.setName` and instead throws on validation error. Previously, if the `error` option was set, the handler was invoked if a validation error occurred on `Parse.Object.set`, and if no handler was set, an error was thrown on `Parse.Object.save`. The new behavior is that an error is thrown at `Parse.Object.set`. For example, instead of using `Parse.Object.set(key, value, { error: ... })` wrap `Parse.Object.set(key, value)` into a `try/catch` block. ([52ddaee](52ddaee))
|
🎉 This change has been released in version 6.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue
Using json true option on findAll caps the results at the limit or batchSize option.
This is because
results[results.length - 1].idthe returned objects don't haveidcausing the loop to break.Approach
json: trueTasks